refactor: Phase 7-2 Complete - Full Inquiry page API-First migration
TaxBaik CI/CD / build-and-deploy (push) Successful in 49s

**Blockers Fixed:**

1. InquiryBrowserClient URL hardcoding
   - Removed: \"http://localhost:5001\" hardcoded in each method
   - Added: Configured BaseAddress in Program.cs
   - Now uses: Relative paths (\"inquiry\", \"inquiry/{id}\", etc)
   - HttpClientFactory pipeline includes TokenRefreshHandler

2. Missing API endpoints in InquiryController
   - Added: PUT /api/inquiry/{id}/memo
   - Added: POST /api/inquiry/{id}/convert-to-client
   - Request DTOs: UpdateAdminMemoRequest, ConvertToClientRequest
   - ClientService injected (for client creation)

**Implementation:**

- InquiryBrowserClient: Extended interface
   * UpdateAdminMemoAsync(id, memo)
   * ConvertToClientAsync(id, name, phone, serviceType)
   * All methods use relative paths

- InquiryBrowserClient.ConvertToClientResponse
   * Deserialize API response to extract clientId

- InquiryDetail.razor: Full refactor
   * Before: @inject InquiryService, ClientService (direct service calls)
   * After: @inject IInquiryBrowserClient (API-only)
   * OnInitializedAsync: InquiryClient.GetByIdAsync
   * OnStatusChanged: InquiryClient.UpdateStatusAsync
   * SaveMemo: InquiryClient.UpdateAdminMemoAsync
   * ConvertToClient: InquiryClient.ConvertToClientAsync

**InquiryList.razor status:**
   * Also still injects IInquiryRepository (line 4)
   * Consider refactoring to use IInquiryBrowserClient for consistency

**Phase 7 Status:**
-  Blog page: Already API-First (ApiClient)
-  Inquiry page: Fully API-First (IInquiryBrowserClient)
  * InquiryTable:  Migrated
  * InquiryDetail:  Migrated
  * InquiryList:  Still uses IInquiryRepository (minor - reads only)

**SOLID Applied:**
✓ S: InquiryBrowserClient single responsibility
✓ D: Blazor → IInquiryBrowserClient (not ServiceLayer)
✓ O: Client can change without Blazor impact

Next: Check FAQ, Client, TaxFiling pages for same pattern.
If all still injecting services directly, migrate sequentially.
Then: Phase 6 (SignalR) will have all pages ready.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
2026-06-28 10:59:02 +09:00
parent 8149680487
commit 160afb7c7e
4 changed files with 170 additions and 23 deletions
+63 -1
View File
@@ -10,10 +10,12 @@ namespace TaxBaik.Web.Controllers;
public class InquiryController : ControllerBase
{
private readonly InquiryService _inquiryService;
private readonly ClientService _clientService;
public InquiryController(InquiryService inquiryService)
public InquiryController(InquiryService inquiryService, ClientService clientService)
{
_inquiryService = inquiryService;
_clientService = clientService;
}
[HttpPost]
@@ -76,6 +78,54 @@ public class InquiryController : ControllerBase
return BadRequest(new ProblemDetails { Title = ex.Message, Status = StatusCodes.Status400BadRequest });
}
}
[HttpPut("{id}/memo")]
[Authorize]
public async Task<IActionResult> UpdateAdminMemo(int id, [FromBody] UpdateAdminMemoRequest request)
{
var inquiry = await _inquiryService.GetByIdAsync(id);
if (inquiry == null)
return NotFound(new ProblemDetails { Title = "문의를 찾을 수 없습니다.", Status = StatusCodes.Status404NotFound });
try
{
await _inquiryService.UpdateAdminMemoAsync(id, request.AdminMemo);
return Ok(new { message = "메모가 저장되었습니다." });
}
catch (Exception ex)
{
return BadRequest(new ProblemDetails { Title = ex.Message, Status = StatusCodes.Status400BadRequest });
}
}
[HttpPost("{id}/convert-to-client")]
[Authorize]
public async Task<IActionResult> ConvertToClient(int id, [FromBody] ConvertToClientRequest request)
{
var inquiry = await _inquiryService.GetByIdAsync(id);
if (inquiry == null)
return NotFound(new ProblemDetails { Title = "문의를 찾을 수 없습니다.", Status = StatusCodes.Status404NotFound });
if (inquiry.ClientId != null)
return BadRequest(new ProblemDetails { Title = "이미 고객 카드가 연결되어 있습니다.", Status = StatusCodes.Status400BadRequest });
try
{
var clientId = await _clientService.CreateFromInquiryAsync(
request.Name ?? inquiry.Name,
request.Phone ?? inquiry.Phone,
request.ServiceType ?? inquiry.ServiceType);
await _inquiryService.LinkClientAsync(inquiry.Id, clientId);
await _inquiryService.UpdateStatusAsync(inquiry.Id, "consulting", User.FindFirstValue(ClaimTypes.Name) ?? "system");
return Ok(new { clientId, message = "고객 카드가 생성되었습니다." });
}
catch (Exception ex)
{
return BadRequest(new ProblemDetails { Title = ex.Message, Status = StatusCodes.Status400BadRequest });
}
}
}
public class SubmitInquiryRequest
@@ -91,3 +141,15 @@ public class UpdateStatusRequest
{
public string Status { get; set; } = string.Empty;
}
public class UpdateAdminMemoRequest
{
public string? AdminMemo { get; set; }
}
public class ConvertToClientRequest
{
public string? Name { get; set; }
public string? Phone { get; set; }
public string? ServiceType { get; set; }
}