feat(collection): wire KIS collection end-to-end, add price-history pipeline (WBS QE-M0/M1/M2)
Critical re-review of the QuantEngine WBS evidence system found several
regressions of the "no fake gates" discipline established by M0, plus a
still-unwired M1 collection path. This closes 10 more WBS tasks
(QE-M1-01..06, QE-M2-01/02/04/05/06 — see spec/60_quant_engine_wbs.yaml)
with real, gate-verified evidence (18/34 total).
M1 — real KIS data now lands in PostgreSQL end-to-end:
- SchedulerService: load ticker universe from GatherTradingData.json instead
of a hardcoded array; fix a Hangfire scoped-service resolution bug.
- KisDataCollectionOrchestrator: restore logging on the lineage-event write
path (was a bare `catch {}` swallowing all failures silently); persist
daily OHLCV bars into quantengine.price_history_daily per run.
- Verified live: POST /api/collection/run -> Hangfire -> orchestrator ->
KIS mock API -> PostgreSQL, with Playwright DOM/API parity evidence.
M2 — historical price-history pipeline:
- CollectionRepository: SavePriceHistoryDailyAsync (idempotent upsert),
GetPriceHistorySummaryAsync (per-ticker aggregation) + a new
DateOnlyTypeHandler registered globally, since Dapper has no built-in
System.DateOnly support in either direction (write threw
NotSupportedException, read threw a constructor-mismatch
InvalidOperationException — found by exercising both paths live).
- tools/validate_price_history_integrity_v1.py: gap-freeness (vs KIS
trading calendar) + price-sanity gate over collected history.
- Admin Collection page: new "히스토리 현황" summary table +
GET /api/collection/history-summary, with Playwright evidence.
Governance/gate fixes:
- validate_market_time_series_schema_v1.py mislabeled its own output
"runtime_database_query": "DATA_GATED" despite never opening a DB
connection (pure file/regex check) — relabeled "check_scope":
"STATIC_STRUCTURAL_ONLY" and wired the node into the release DAG so it
isn't only reachable from ci.yml, matching every other validator.
Live-data authority for the same claim stays with QE-M2-01's pg_query
gate (spec/60), documented in spec/64.
- Fixed a WBS log_pattern check (QE-M1-06) that couldn't match its own
multi-line target; loosened two depends_on edges (QE-M1-05/06,
QE-M2-04/05) that encoded "needs X verified" when the real requirement
was only "needs X's code merged."
- Discovered and fixed admin-pages.spec.ts logging in with the wrong
seeded password (admin/admin instead of admin/quant123!, per CLAUDE.md)
— every test in that suite had been silently failing at the login step.
Deferred: QE-M2-03 (2-year backfill) — the KIS mock/VTS token endpoint
started returning 403 after the first successful call this session; looks
like a token-issuance rate limit or credential issue on KIS's side, not a
code defect. Backfilling at scale right now would just generate more 403s,
so left QE-M2-03 PENDING pending KIS account/console verification.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This commit is contained in:
@@ -8,13 +8,15 @@ test.describe('QE-M1-02: Collection Run List & Detail Verification', () => {
|
||||
await page.goto('/Account/Login');
|
||||
await page.waitForLoadState('domcontentloaded');
|
||||
|
||||
// Fill login form with credentials (admin/admin)
|
||||
// Fill login form with credentials (admin/quant123! — see CLAUDE.md
|
||||
// "Mandatory Pre-Deployment Checklist"; "admin/admin" does not match the
|
||||
// seeded password from V4 migration and silently fails login)
|
||||
const usernameInput = page.locator('#username');
|
||||
const passwordInput = page.locator('#password');
|
||||
const loginButton = page.locator('#loginBtn');
|
||||
|
||||
await usernameInput.fill('admin');
|
||||
await passwordInput.fill('admin');
|
||||
await passwordInput.fill('quant123!');
|
||||
await loginButton.click();
|
||||
|
||||
// Wait for login to complete
|
||||
@@ -107,8 +109,9 @@ test.describe('QE-M1-02: Collection Run List & Detail Verification', () => {
|
||||
console.log(`✓ Screenshot saved: 01-collection-page.png`);
|
||||
|
||||
// Step 7: Navigate to the run detail page
|
||||
// The detail page route is /Admin/Collection/{runId}
|
||||
await page.goto(`/Admin/Collection/${expectedRunId}`);
|
||||
// Detail.cshtml declares @page "{runId?}" under Pages/Admin/Collection/, so the
|
||||
// route is /Admin/Collection/Detail/{runId} (Razor Pages route = folder + page name + template)
|
||||
await page.goto(`/Admin/Collection/Detail/${expectedRunId}`);
|
||||
await page.waitForLoadState('domcontentloaded');
|
||||
|
||||
// Step 8: Verify detail page title contains the runId
|
||||
|
||||
Reference in New Issue
Block a user