kjh2064
b1e38ac374
Completes VS-10/VS-12/VS-14 and makes the solution and Host actually
build and boot for the first time on this branch (main did not build
before this commit).
Root-cause fixes required to reach a green build/boot (not scoped to
J/K/L but blocking any verification of it):
- Restore Polly PackageVersion accidentally deleted from
Directory.Packages.props (broke KArtSell.Host).
- Remove MediatR dependency from Compliance/VS-04 (package was never
installed; ICommand/ICommandHandler/IMediator never existed) and
wire Endpoint -> Handler directly per this repo's convention.
- Migrate FastEndpoints v5 API calls (SendOkAsync/SendAsync/
SendCreatedAtAsync/SendNotFoundAsync, Description().WithName()) to
the v7 Send.* fluent API across ~10 endpoint files.
- Fix migrations 0036/0038/0039/0040: rewritten from invalid T-SQL
(`IF NOT EXISTS ... BEGIN ... END`) to idiomatic Postgres
(`CREATE TABLE/INDEX IF NOT EXISTS`) — these could not apply to any
fresh database before this fix.
- Collapse 3 duplicate cross-cutting abstractions that shadowed the
BuildingBlocks versions and caused type-mismatch compile errors:
IKrxDataService, IOutboxWriter (ReconcileTradeHandler), IClock
(ApprovalWorkflow/ApprovalPolicy).
- Inject IClock (BuildingBlocks.Time) in place of direct
DateTime.Now/UtcNow across 19 files to satisfy the architecture
test AGENTS.md#DateTime-abstraction rule (13/13 architecture tests
now pass, was 12/13).
- Register all new and previously-unregistered slices in
Program.cs DI (SellDecision, TradeExecution, PortfolioReconciliation,
Compliance, Features/ApprovalWorkflow) — the Host had never
successfully completed a boot with this code present.
- Disable ("[DontRegister]") the older, route-colliding
ApprovalWorkflow/ (Workstream H) endpoint set in favor of
Features/ApprovalWorkflow/ (Workstream G, matches the documented
Features/<Slice>/ convention); kept for its existing test coverage.
See TECH_DEBT-017 for the follow-up decision needed.
Verified: dotnet build 0 errors/0 warnings; architecture tests 13/13;
unit tests 54/54 + 18/18; integration tests 34/36 (2 failures are a
local test-DB migration-journal/schema mismatch, not a code defect);
Host boots cleanly and registers all 34 endpoints.
New tech debt recorded: DEBT-017 (duplicate VS-03 implementation),
DEBT-018 (outbox write not co-transactional with entity write in
TradeExecution/PortfolioReconciliation), DEBT-019 (duplicate
BuildingBlocks-shadowing abstractions, partially resolved).
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
56 lines
2.4 KiB
C#
56 lines
2.4 KiB
C#
namespace KArtSell.Modules.ModelOperations.Compliance;
|
|
|
|
/// <summary>
|
|
/// Immutable audit event for compliance trail (INSERT-only, no UPDATE/DELETE).
|
|
/// Links to model operations, approvals, sell decisions, and trades.
|
|
/// </summary>
|
|
public class AuditEvent
|
|
{
|
|
public Guid Id { get; set; }
|
|
public required string EventType { get; set; } // MODEL_CREATED, APPROVAL_PROPOSED, APPROVAL_APPROVED, MODEL_ACTIVATED, SELL_DECISION_MADE, SELL_EXECUTED, BACKTEST_COMPLETED, DATA_CORRECTION
|
|
public required string EntityType { get; set; } // MODEL, APPROVAL, SELL_DECISION, TRADE_EXECUTION
|
|
public Guid EntityId { get; set; }
|
|
public required string ActorEmail { get; set; }
|
|
public string? ActorRole { get; set; } // MAKER, CHECKER, SRE, SYSTEM
|
|
public DateTime EventAt { get; set; }
|
|
public required string Result { get; set; } // SUCCESS, FAILURE, PARTIAL
|
|
public string? ErrorMessage { get; set; }
|
|
public Dictionary<string, object>? Details { get; set; } // Event-specific metadata
|
|
public string[]? EvidenceLinks { get; set; } // S3 artifact URLs
|
|
public string? IpAddress { get; set; }
|
|
public string? UserAgent { get; set; }
|
|
public DateTime PublishedAt { get; set; }
|
|
public Guid CorrelationId { get; set; } // Links related events in audit trail
|
|
public int Revision { get; set; }
|
|
}
|
|
|
|
/// <summary>
|
|
/// Event type enumeration (reference data).
|
|
/// </summary>
|
|
public static class AuditEventTypes
|
|
{
|
|
public const string ModelCreated = "MODEL_CREATED";
|
|
public const string ModelArchived = "MODEL_ARCHIVED";
|
|
public const string ApprovalProposed = "APPROVAL_PROPOSED";
|
|
public const string ApprovalApproved = "APPROVAL_APPROVED";
|
|
public const string ApprovalRejected = "APPROVAL_REJECTED";
|
|
public const string ModelActivated = "MODEL_ACTIVATED";
|
|
public const string ModelDeactivated = "MODEL_DEACTIVATED";
|
|
public const string SellDecisionMade = "SELL_DECISION_MADE";
|
|
public const string SellExecuted = "SELL_EXECUTED";
|
|
public const string BacktestCompleted = "BACKTEST_COMPLETED";
|
|
public const string DataCorrection = "DATA_CORRECTION";
|
|
public const string ComplianceAudit = "COMPLIANCE_AUDIT";
|
|
}
|
|
|
|
/// <summary>
|
|
/// Entity types for audit events.
|
|
/// </summary>
|
|
public static class AuditEntityTypes
|
|
{
|
|
public const string Model = "MODEL";
|
|
public const string Approval = "APPROVAL";
|
|
public const string SellDecision = "SELL_DECISION";
|
|
public const string TradeExecution = "TRADE_EXECUTION";
|
|
}
|