 kjh2064
|
26d1855365
|
PR 4d: Finalize permanent deferral decisions for DEBT-003~006 and DEBT-008
Governance: Updated TECH_DEBT_REGISTER.md per AGENTS.md v16.0 cost-benefit analysis.
Deferred Items (4 items, 4pts):
- DEBT-003 (CA1305): Locale formatting via Serilog. Breaking change risk exceeds benefit.
- DEBT-004 (CA1707): xUnit test naming convention (underscores). Not a defect, acceptable standard.
- DEBT-005 (CA1861): Static readonly array allocations. Negligible perf; readability priority.
- DEBT-006 (xUnit2031): Assert.Single overload nit. Style preference, not safety-critical.
Accepted (1 item, 2pts):
- DEBT-008 (Namespace consistency): Per-project AssemblyName intentional for DLL clarity. Trade-off accepted.
Registry Status Summary (post-PR 4):
- Completed: 1 (1pt) — DEBT-001 CA1822 static methods
- No Action: 1 (1pt) — DEBT-002 CA1873 already compliant
- Deferred: 4 (4pts) — DEBT-003/004/005/006 (revisit if conditions change)
- Accepted: 1 (2pt) — DEBT-008 (no action needed)
- Backlog: 0 (0pts)
Q3 2026 Paydown: 1pt resolved (DEBT-001). Target 4pts (20% of 20pt total).
Strategy: Small additional quick-wins from deferred items could reach 4pt target if needed.
All 40 tests PASS (17 ModelOps + 18 SignalEngine + 5 Architecture)
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
2026-08-02 06:03:02 +09:00 |
|
|
kjh2064
|
6a31bc3737
|
PR 4b: Apply CA1822 static method modifiers + Gitea Actions secrets guidance
Completed DEBT-001 paydown (1pt) by making three pure-function methods static:
- ScheduleOccurrencePlanner.GetNextDueAt (no instance state accessed)
- PromotionGateEvaluator.Evaluate (evidence gate only, no mutations)
- EvaluationWindowPlanner.Plan (deterministic date calculation)
Changes:
- Added `static` modifier to three domain methods
- Updated call sites: ModelOperationsDispatcherJob, tests
- Removed unnecessary DI registrations (ModelOperationsModule)
- Eliminated instance creation overhead in tests
Test Results: 40/40 PASS (17 ModelOps + 18 SignalEngine + 5 Architecture)
Documentation:
- Updated TECH_DEBT_REGISTER.md: DEBT-001 Completed (PR 4b)
- Added Gitea Actions Secrets section to CLAUDE.md documenting:
- KRX_API_KEY, OPENDART_API_KEY, KIS_API_KEY storage location
- CI/CD usage pattern
- Local dev guidance
Per AGENTS.md v16.0: Code changes are performance improvements, not suppressions.
Quarterly paydown: +1pt (target 4pts for 20% Q3 2026)
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
2026-08-02 05:59:01 +09:00 |
|
|
kjh2064
|
88ea5edef5
|
fix: Replace IReadOnlySet/IReadOnlyDictionary with HashSet/Dictionary for performance (CA1859) and use LoggerMessage delegates (CA1848)
ci / backend (push) Failing after 1s
ci / static (push) Failing after 5s
ci / frontend (push) Failing after 4s
Source: CLAUDE.md observability section - Serilog structured logging and performance are first-class concerns
Slice: ModelOperations/Scheduling, Domain/ModelFeedbackCycle
Policy: CA1859 (concrete types over interfaces), CA1848 (LoggerMessage delegates)
Changes:
- ScheduledModelOperationJob: LoggerMessage.Define for warning/info logs
- ModelOperationsDispatcherJob: LoggerMessage.Define for error logs
- ModelOperationExecution: Dictionary<State, HashSet<State>> state machine
- ModelFeedbackCycle: Dictionary<State, HashSet<State>> state machine
Verification:
- dotnet build: 0 errors, 0 warnings
- dotnet test: 41/41 tests passed (ArchitectureTests 5, ModelOperations 17, SignalEngine 18)
Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
|
2026-08-02 05:37:45 +09:00 |
|
|
kjh2064
|
87705c1f6a
|
fix: Resolve backend build errors - add RootNamespace, OutputType, GlobalUsings, and code analysis settings
ci / backend (push) Failing after 1s
ci / static (push) Failing after 5s
ci / frontend (push) Failing after 6s
|
2026-08-02 05:30:00 +09:00 |
|
|
kjh2064
|
dcd1322d41
|
Initial commit: Add project files
ci / backend (push) Failing after 12s
ci / frontend (push) Failing after 19s
ci / static (push) Failing after 45s
|
2026-08-02 05:15:36 +09:00 |
|