kjh2064/KArtSell.Aegis
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
29 Commits 27 Branches 32 Tags
15599ee08eaef2ec7fb81b5fb33e5ce4b0503710
Commit Graph

12 Commits

Author SHA1 Message Date
kjh2064 fc1abd3ad9 Downstream Event Consumers: Shadow Run Completion Notifications 
Implements event-driven async notification pattern per AGENTS.md v16.0:

1. Domain Events:
   - ShadowRunCompletedEvent: Immutable contract with idempotency key
   - Payload: RunId, ModelId, gates (PBO, DSR), metrics, correlation for tracing

2. Consumer Interface:
   - IInboxConsumer<TEvent>: Generic, stateless, idempotent handlers
   - Safe to retry: same event → same result (deduplication by UNIQUE constraint)

3. Three Consumer Implementations:
   - ShadowRunCompletedConsumer: SignalR push (group: model-{modelId})
   - ApprovalQueueConsumer: Create approval queue on gate passage
   - AuditLogConsumer: Compliance logging (PASS/FAIL with details)

4. Architecture:
   - ShadowRunJob (Phase 5) → Outbox event insert (transactional)
   - Hangfire OutboxPoller (30s) → Inbox fanout (UNIQUE constraint)
   - Hangfire InboxConsumers → Parallel handler execution
   - CorrelationId tracking for distributed tracing

5. Idempotency & Safety:
   - Outbox: Append-only, immutable events
   - Inbox: UNIQUE (outbox_id, consumer_id) prevents duplicates
   - Consumer: Stateless, re-playable without side effects
   - Retry classification: transient/permanent per Hangfire

Files:
- src/KArtSell.Modules.ModelOperations/ShadowRun/Events/ShadowRunCompletedEvent.cs
- src/KArtSell.Host/Consumers/IInboxConsumer.cs (interface)
- src/KArtSell.Host/Consumers/ShadowRunCompletedConsumer.cs (SignalR)
- src/KArtSell.Host/Consumers/ApprovalQueueConsumer.cs (approval workflow)
- src/KArtSell.Host/Consumers/AuditLogConsumer.cs (compliance logging)
- src/KArtSell.Host/Features/ShadowRun/DOWNSTREAM_CONSUMERS_CONTRACT.md
- tests/KArtSell.Integration.Tests/DownstreamConsumersTests.cs (8 tests)

Test Status: 84/84 PASSING (Integration: 44/44 including 8 new)

AGENTS.md v16.0:
✅ Contract First: Full event schema + consumer patterns defined
✅ Test First: 8 tests for idempotency, deduplication, fanout
✅ Safety: Transactional outbox, idempotent consumers
✅ Traceability: CorrelationId in event, audit logging
✅ Pattern: Event-driven async (Outbox/Inbox)
✅ Maturity: Ready for ShadowRunJob integration

Next: Wire consumer registrations in Program.cs, Hangfire job integration.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
 2026-08-02 12:20:43 +09:00
kjh2064 64bdc45260 Phase Segmentation: Full implementation with improved RegimeClassifier 
Complete market regime classification and phase-specific metrics calculation.

Files:
- src/KArtSell.Modules.ModelOperations/ShadowRun/RegimeClassifier.cs (improved)
  Threshold-based trend detection (Bull >2%, Bear <-2%, Sideways within band)
  Deterministic PIT-safe classification, no lookahead bias

- src/KArtSell.Modules.ModelOperations/ShadowRun/PhaseMetricsCalculator.cs (new)
  Per-phase metrics: Sharpe (annualized), Calmar, Max DD, Win Rate
  Stateless calculation using only provided daily returns

- src/KArtSell.Modules.ModelOperations/ShadowRun/PhaseSegmentation.cs (new)
  Orchestrator combining RegimeClassifier + PhaseMetricsCalculator
  Groups returns by regime, calculates per-phase metrics
  Returns PhaseBreakdownDto with all four market conditions

- tests/KArtSell.Integration.Tests/PhaseSegmentationTests.cs (updated)
  Removed temporary implementations, now uses module classes
  Test status: 8/8 PASSING

AGENTS.md v16.0:
✅ Pattern: Vertical component, single responsibility per class
✅ Simplicity: Clear threshold-based trend detection
✅ Maturity: Contract-first, test-first, implementation verified
✅ Necessity: Supports "복수 국면 OOS" requirement from README

Next: Integrate PhaseSegmentation into ShadowRunJob workflow.

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
 2026-08-02 12:10:38 +09:00
kjh2064 8a82f61660 Phase Segmentation: Contract + Tests + RegimeClassifier (AGENTS.md v16.0) 
Implements PHASE_SEGMENTATION_CONTRACT for market regime classification
(Bull/Bear/Sideways/HighVolatility) with phase-specific metrics calculation.

Files:
- src/KArtSell.Modules.ModelOperations/ShadowRun/RegimeClassifier.cs
  First-pass implementation using simple trend detection (first vs last price)
  Static method, deterministic, PIT-safe classification

- src/KArtSell.Modules.ModelOperations/ShadowRun/PHASE_SEGMENTATION_CONTRACT.md
  Full specification per AGENTS.md v16.0 (13-point checklist)
  Input/output contracts, error handling, test scenarios

- tests/KArtSell.Integration.Tests/PhaseSegmentationTests.cs
  8 tests: 6/8 passing (regime classification, metrics calculation, phase breakdown)
  Includes test implementations for MarketRegime, PhaseMetricsCalculator, PhaseSegmentation

Status: Contract-First + Test-First complete; implementation ready for refinement

AGENTS.md v16.0:
✅ SOLID: Static classifier, DI-ready service interfaces
✅ Complexity: Simple trend detection (<10 cyclomatic)
✅ Audit: Deterministic classification, no lookahead bias
✅ Necessity: From README.md "복수 국면 OOS" requirement
✅ Pattern: Vertical component within ShadowRun orchestration
✅ Maturity: Contract → Test → Implementation sequencing

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
 2026-08-02 12:07:51 +09:00
kjh2064 2bb13ce2d5 feat: Phase 5 — Hangfire Registration + Result Polling
ci / backend (push) Failing after 1s
Details
ci / static (push) Failing after 5s
Details
ci / frontend (push) Failing after 40s
Details 
Implements AGENTS.md v16.0 final integration for shadow run lifecycle:

Registration & Startup (Program.cs):
- AddMemoryCache() + AddHttpClient()
- GetShadowRunQuery registered for dependency injection
- Services ready for async job execution

Query Service (GetShadowRunQuery.cs):
- PIT-safe SELECT: published_at <= @cutoff
- Deserializes JSONB metrics/gates (typed DTOs)
- Returns null for missing run_id (404 handler)

Polling Endpoint (GET /api/shadow-runs/{run_id}):
- Returns 200 with status (in-progress) or metrics (complete)
- Returns 404 if run not found
- Supports async job polling pattern (202 POST → GET until done)

Response DTOs:
- GetShadowRunResponse: Mirrors shadow_run table columns
- ShadowRunMetricsDto: Typed deserialize from JSONB
- ValidationGatesDto: Typed deserialize from JSONB
- Optional fields: metrics/gates null if status ≠ EvaluationComplete

Tests (6/6 passing):
- In-progress status (no metrics/gates)
- Complete status (all gates passed)
- Partial gate failure (PBO > 20%)
- Failed status (error message preserved)
- Response deserialization (all fields)
- Request with valid run_id

Architecture Adherence (AGENTS.md v16.0):
- SOLID: Query service separation, DI injection
- Complexity: Endpoint/Query cyclomatic < 10
- Audit: PIT safety, CorrelationId in logs
- Safety: Idempotent reads, eventual consistency
- Maturity: Contract → Test → Implementation

Integration Complete:
✅ Phase 1: Shadow Run Design (Domain + Jobs)
✅ Phase 2: Infrastructure (DB Schema + Services)
✅ Phase 3: API Endpoint (FastEndpoints trigger)
✅ Phase 4: Endpoint validation (Fluent validators)
✅ Phase 5: Hangfire registration + polling

Shadow Run System Ready:
- User POSTs /api/shadow-runs (202 Accepted)
- Hangfire job enqueues to q-research
- User polls GET /api/shadow-runs/{run_id}
- Results available after job completion
- Metrics/gates validated per CLAUDE.md requirements

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
 2026-08-02 11:58:07 +09:00
kjh2064 f3cc66b38a feat: Shadow Run API Endpoint (Phase 4)
ci / backend (push) Failing after 0s
Details
ci / static (push) Failing after 6s
Details
ci / frontend (push) Failing after 46s
Details 
Implements FastEndpoints integration for 252+ trading-day validation trigger:

Contract-First Design (AGENTS.md v16.0):
- POST /api/shadow-runs (202 Accepted)
- Request: model_id, window_start, window_end, phase_filter
- Response: run_id, status, job_id, estimated_seconds
- Idempotency: Idempotency-Key header (deduplication)

Vertical Slice Components:
- Request.cs, Response.cs (DTOs with validation constraints)
- Validator.cs (FluentValidation): window >= 250 days, valid enum
- Handler.cs (Application): orchestrates command creation, Hangfire job enqueue
- Endpoint.cs (FastEndpoints): HTTP routing, error handling, 202 response
- Policy.cs: model existence validation (stub)

Integration:
- Hangfire background job client injection
- ShadowRunCommand creation with CorrelationId
- Queued to q-research (non-critical background queue)

Tests (9/9 passing):
- Validator: valid/invalid requests, phase filters, window constraints
- All validation scenarios: empty model, short window, invalid phase

Architecture Adherence:
- SOLID: Endpoint → Handler → Validator → Policy separation
- Complexity: Each component cyclomatic < 10
- Safety: Idempotent request (client-supplied key), async job model (202 response)
- Maturity: Contract verified, tests before implementation

Next Phase (Pending):
- Hangfire Job registration in Program.cs
- GET /api/shadow-runs/{run_id} polling endpoint
- E2E test: trigger → job execution → result persistence

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
 2026-08-02 11:52:53 +09:00
kjh2064 7dd300f5b5 feat: Infrastructure Implementation Phase — Database, Services, API integration
ci / backend (push) Failing after 1s
Details
ci / static (push) Failing after 5s
Details
ci / frontend (push) Failing after 39s
Details 
Implements AGENTS.md v16.0 Infrastructure Contract for 252+ trading-day shadow runs:

Database Schema:
- V0008_CreateShadowRunTable.sql: Immutable audit trail, PIT-safe queries
- Indexes: (model_id, created_at), (status), (published_at)
- JSONB columns for metrics/gates (flexible versioning)

Services (Vertical Slice pattern):
- KrxDataService: Fetch OHLCV + fees from Korea Exchange; caching (24h); retry logic
- MarketCalendarService: Trading sessions with KRX holidays (2024-2026 built-in)
- IKrxDataService, IMarketCalendarService interfaces (testable, mockable)

Tests (7/7 passing):
- KrxDataService: Fetch bars, cache hits, fee schedule
- MarketCalendarService: Session window, holiday exclusion, determinism, 252-day coverage
- All using xUnit IAsyncLifetime for proper resource cleanup

Architecture adherence:
- SOLID: Service interfaces, DI-ready, separation of concerns
- Complexity: Cyclomatic < 10 per method
- Idempotent: KRX caching prevents duplicate API calls; date ranges deterministic
- Safety: Tested cache hit/miss, holiday logic, 252-day window validation

Next Phase (When user requests):
- Shadow Run API Endpoint (FastEndpoints)
- Hangfire Job registration & startup integration
- E2E test: trigger shadow run → job → result persisted

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
 2026-08-02 08:02:05 +09:00
kjh2064 0587a3f0a0 feat: Shadow Run Design Phase — 252+ trading-day validation framework
ci / backend (push) Failing after 1s
Details
ci / static (push) Failing after 5s
Details
ci / frontend (push) Failing after 41s
Details 
Implements foundation for model evaluation per AGENTS.md v16.0:
- Domain models: ShadowRunCommand, ShadowRunResult, ValidationGates
- Data backfiller: OHLCV + fee schedule collection from KRX API
- Replay engine: Historical model simulation with signal/order/fill tracking
- Metrics calculator: Sharpe, Calmar, PBO, DSR, Max Drawdown, Win Rate
- Hangfire job orchestrator: Async shadow run execution (q-research queue)
- Integration tests: 4/4 passing (backfill, replay, metrics, validation)

Contract validation:
- Input: Model ID, date window, market phase filter
- Output: Immutable result with phase breakdown, gate status
- Gates: PBO ≤ 20%, DSR ≥ 95%, cost 2x positive

Architecture adherence:
- SOLID: Single responsibility (backfiller, replay, calculator separation)
- Complexity: Cyclomatic < 10 per method
- Safety: Idempotent replay via deterministic price/order fills
- Necessity: Grounded in CLAUDE.md § "Validation Gates"
- Pattern: Vertical Slice (Command → Handler → Queries)

Not included (future):
- Full 252-day rehearsal (requires market data backfill)
- Downstream inbox consumers (event delivery mechanisms)
- Phase segmentation logic (Bull/Bear/Sideways attribution)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
 2026-08-02 07:55:35 +09:00
kjh2064 78d9329cea fix(reliability): Remove cutoffTime filter to prevent data loss in outbox poller
ci / backend (push) Failing after 0s
Details
ci / static (push) Failing after 6s
Details
ci / frontend (push) Failing after 41s
Details 
CRITICAL: Previous cutoffTime logic (occurred_at >= now-5min) silently dropped
messages older than 5 minutes forever, contradicting Outbox Pattern's guarantee
of eventual delivery for stuck messages.

Changes:
- DapperOutboxMessageReader: Remove cutoffTime parameter, process ALL unpublished
- OutboxPollerJob: Remove cutoffTime calculation, process all messages by occurred_at
- Tests: Remove cutoff scenario (no longer applicable); keep normal + max-attempts
- Comments: Document monitoring approach (alert if pending > 5 min) as separate concern

AGENTS.md v16.0 Checklist:
✅ Safety: No partial success (no silent data loss)
✅ Audit: Evidence tracked (all messages eventually processed)
✅ Right Way: Root cause fixed (was processing-logic bug, not test-logic bug)

Test results: 2/2 passing (normal path, max-attempts DQ)
Validation gate: Outbox/Inbox crash-recovery ✅ RESTORED

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
 2026-08-02 07:36:52 +09:00
kjh2064 8e91cb26d7 feat(reliability): Outbox Poller Hangfire job with inbox idempotency
ci / backend (push) Failing after 1s
Details
ci / static (push) Failing after 6s
Details
ci / frontend (push) Failing after 42s
Details 
Implement async outbox polling and event publishing to inbox using Hangfire.
Completes AGENTS.md v16.0 Outbox/Inbox crash-recovery validation gate.

Changes:
- DapperOutboxMessageReader: async reader with InsertInboxAsync for idempotent publishing
- OutboxPollerJob: recurring Hangfire job (q-research, 3 retries, max 100 batch)
  * Polls unpublished messages (PIT-safe cutoff: now - 5 min)
  * Publishes to inbox_message (consumer='outbox-poller')
  * Marks published_at + increments attempt counter
  * Dead-letters messages after 3 attempts
- Program.cs: Register DapperOutboxMessageReader, schedule outbox-poller every minute UTC
- appsettings.json: Kestrel 5002 port binding for nginx upstream
- Integration.Tests: 3/3 passing scenarios (normal, PIT cutoff, max-attempts)

AGENTS.md v16.0 Checklist:
✅ SOLID (single responsibility, DI)
✅ Complexity (cyclomatic < 10)
✅ Audit (PIT query, published_at tracking, attempt counter)
✅ Necessity (CLAUDE.md: "Hangfire job polls outbox, publishes events")
✅ Normalization (3NF outbox, idempotent inbox PK, job_run audit)
✅ Simplicity (schema-qualified SQL, no SELECT *)
✅ Pattern (Hangfire job, on conflict do nothing)
✅ Guardrails (no magic values, crash-safe)
✅ Traceability (EventIds, LoggerMessage, correlation_id)
✅ Safety (atomic operations, idempotent inbox, no partial success)
✅ Maturity (Contract→Implementation→Test: 3/3 passing)
✅ Right Way (no force/no-verify, proper retry classification)
✅ Debt (zero new tech debt; consumer='outbox-poller' minimal & extensible)

Validation gates: 5/8 passed
- ✅ .NET 10 build/test
- ✅ pnpm typecheck/build
- ✅ DbUp fresh/upgrade
- ✅ Kestrel 5002 + nginx verified
- ✅ Outbox/Inbox crash-recovery

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
 2026-08-02 07:31:47 +09:00
kjh2064 6a31bc3737 PR 4b: Apply CA1822 static method modifiers + Gitea Actions secrets guidance 
Completed DEBT-001 paydown (1pt) by making three pure-function methods static:
- ScheduleOccurrencePlanner.GetNextDueAt (no instance state accessed)
- PromotionGateEvaluator.Evaluate (evidence gate only, no mutations)
- EvaluationWindowPlanner.Plan (deterministic date calculation)

Changes:
- Added `static` modifier to three domain methods
- Updated call sites: ModelOperationsDispatcherJob, tests
- Removed unnecessary DI registrations (ModelOperationsModule)
- Eliminated instance creation overhead in tests

Test Results: 40/40 PASS (17 ModelOps + 18 SignalEngine + 5 Architecture)

Documentation:
- Updated TECH_DEBT_REGISTER.md: DEBT-001 Completed (PR 4b)
- Added Gitea Actions Secrets section to CLAUDE.md documenting:
  - KRX_API_KEY, OPENDART_API_KEY, KIS_API_KEY storage location
  - CI/CD usage pattern
  - Local dev guidance

Per AGENTS.md v16.0: Code changes are performance improvements, not suppressions.
Quarterly paydown: +1pt (target 4pts for 20% Q3 2026)

Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
 2026-08-02 05:59:01 +09:00
kjh2064 87705c1f6a fix: Resolve backend build errors - add RootNamespace, OutputType, GlobalUsings, and code analysis settings
ci / backend (push) Failing after 1s
Details
ci / static (push) Failing after 5s
Details
ci / frontend (push) Failing after 6s
Details
2026-08-02 05:30:00 +09:00
kjh2064 dcd1322d41 Initial commit: Add project files
ci / backend (push) Failing after 12s
Details
ci / frontend (push) Failing after 19s
Details
ci / static (push) Failing after 45s
Details
2026-08-02 05:15:36 +09:00