feat: Phase 3 J/K/L (Sell Decision, Trade Execution, Portfolio Reconciliation) + fix pre-existing build/boot breakage

Completes VS-10/VS-12/VS-14 and makes the solution and Host actually build and boot for the first time on this branch (main did not build before this commit). Root-cause fixes required to reach a green build/boot (not scoped to J/K/L but blocking any verification of it): - Restore Polly PackageVersion accidentally deleted from Directory.Packages.props (broke KArtSell.Host). - Remove MediatR dependency from Compliance/VS-04 (package was never installed; ICommand/ICommandHandler/IMediator never existed) and wire Endpoint -> Handler directly per this repo's convention. - Migrate FastEndpoints v5 API calls (SendOkAsync/SendAsync/ SendCreatedAtAsync/SendNotFoundAsync, Description().WithName()) to the v7 Send.* fluent API across ~10 endpoint files. - Fix migrations 0036/0038/0039/0040: rewritten from invalid T-SQL (`IF NOT EXISTS ... BEGIN ... END`) to idiomatic Postgres (`CREATE TABLE/INDEX IF NOT EXISTS`) — these could not apply to any fresh database before this fix. - Collapse 3 duplicate cross-cutting abstractions that shadowed the BuildingBlocks versions and caused type-mismatch compile errors: IKrxDataService, IOutboxWriter (ReconcileTradeHandler), IClock (ApprovalWorkflow/ApprovalPolicy). - Inject IClock (BuildingBlocks.Time) in place of direct DateTime.Now/UtcNow across 19 files to satisfy the architecture test AGENTS.md#DateTime-abstraction rule (13/13 architecture tests now pass, was 12/13). - Register all new and previously-unregistered slices in Program.cs DI (SellDecision, TradeExecution, PortfolioReconciliation, Compliance, Features/ApprovalWorkflow) — the Host had never successfully completed a boot with this code present. - Disable ("[DontRegister]") the older, route-colliding ApprovalWorkflow/ (Workstream H) endpoint set in favor of Features/ApprovalWorkflow/ (Workstream G, matches the documented Features/<Slice>/ convention); kept for its existing test coverage. See TECH_DEBT-017 for the follow-up decision needed. Verified: dotnet build 0 errors/0 warnings; architecture tests 13/13; unit tests 54/54 + 18/18; integration tests 34/36 (2 failures are a local test-DB migration-journal/schema mismatch, not a code defect); Host boots cleanly and registers all 34 endpoints. New tech debt recorded: DEBT-017 (duplicate VS-03 implementation), DEBT-018 (outbox write not co-transactional with entity write in TradeExecution/PortfolioReconciliation), DEBT-019 (duplicate BuildingBlocks-shadowing abstractions, partially resolved). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
2026-08-07 19:53:38 +09:00
parent 75f72fbb72
commit b1e38ac374
55 changed files with 5620 additions and 196 deletions
@@ -1,65 +1,56 @@
 -- Migration 0036: Approval workflow schema (VS-03)
 -- Creates tables for model activation approval gates with maker-checker separation

-IF NOT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_name = 'approval_proposals' AND table_schema = 'model_operations')
-BEGIN
-    CREATE TABLE model_operations.approval_proposals (
-        id UUID PRIMARY KEY,
-        model_id UUID NOT NULL REFERENCES model_operations.models(id),
-        status VARCHAR(50) NOT NULL,
-        created_by VARCHAR(255) NOT NULL,
-        created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
-        justification TEXT NOT NULL,
-        effective_at DATE NOT NULL,
-        proposed_at TIMESTAMPTZ,
-        approved_by VARCHAR(255),
-        approved_at TIMESTAMPTZ,
-        approval_notes TEXT,
-        activated_by VARCHAR(255),
-        activated_at TIMESTAMPTZ,
-        published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
-        revision INT NOT NULL DEFAULT 1,
-        correlation_id UUID NOT NULL
-    );
+CREATE TABLE IF NOT EXISTS model_operations.approval_proposals (
+    id UUID PRIMARY KEY,
+    model_id UUID NOT NULL REFERENCES model_operations.models(id),
+    status VARCHAR(50) NOT NULL,
+    created_by VARCHAR(255) NOT NULL,
+    created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    justification TEXT NOT NULL,
+    effective_at DATE NOT NULL,
+    proposed_at TIMESTAMPTZ,
+    approved_by VARCHAR(255),
+    approved_at TIMESTAMPTZ,
+    approval_notes TEXT,
+    activated_by VARCHAR(255),
+    activated_at TIMESTAMPTZ,
+    published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    revision INT NOT NULL DEFAULT 1,
+    correlation_id UUID NOT NULL
+);

-    CREATE INDEX ix_approval_proposals_model_id ON model_operations.approval_proposals(model_id);
-    CREATE INDEX ix_approval_proposals_status ON model_operations.approval_proposals(status);
-    CREATE INDEX ix_approval_proposals_created_by ON model_operations.approval_proposals(created_by);
-    CREATE INDEX ix_approval_proposals_approved_by ON model_operations.approval_proposals(approved_by);
-    CREATE INDEX ix_approval_proposals_correlation_id ON model_operations.approval_proposals(correlation_id);
-END;
+CREATE INDEX IF NOT EXISTS ix_approval_proposals_model_id ON model_operations.approval_proposals(model_id);
+CREATE INDEX IF NOT EXISTS ix_approval_proposals_status ON model_operations.approval_proposals(status);
+CREATE INDEX IF NOT EXISTS ix_approval_proposals_created_by ON model_operations.approval_proposals(created_by);
+CREATE INDEX IF NOT EXISTS ix_approval_proposals_approved_by ON model_operations.approval_proposals(approved_by);
+CREATE INDEX IF NOT EXISTS ix_approval_proposals_correlation_id ON model_operations.approval_proposals(correlation_id);

-IF NOT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_name = 'approval_evidence' AND table_schema = 'model_operations')
-BEGIN
-    CREATE TABLE model_operations.approval_evidence (
-        id UUID PRIMARY KEY,
-        approval_proposal_id UUID NOT NULL REFERENCES model_operations.approval_proposals(id),
-        evidence_type VARCHAR(50) NOT NULL,
-        evidence_url TEXT NOT NULL,
-        reviewer_comment TEXT,
-        published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
-        correlation_id UUID NOT NULL
-    );
+CREATE TABLE IF NOT EXISTS model_operations.approval_evidence (
+    id UUID PRIMARY KEY,
+    approval_proposal_id UUID NOT NULL REFERENCES model_operations.approval_proposals(id),
+    evidence_type VARCHAR(50) NOT NULL,
+    evidence_url TEXT NOT NULL,
+    reviewer_comment TEXT,
+    published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    correlation_id UUID NOT NULL
+);

-    CREATE INDEX ix_approval_evidence_proposal_id ON model_operations.approval_evidence(approval_proposal_id);
-    CREATE INDEX ix_approval_evidence_type ON model_operations.approval_evidence(evidence_type);
-    CREATE INDEX ix_approval_evidence_correlation_id ON model_operations.approval_evidence(correlation_id);
-END;
+CREATE INDEX IF NOT EXISTS ix_approval_evidence_proposal_id ON model_operations.approval_evidence(approval_proposal_id);
+CREATE INDEX IF NOT EXISTS ix_approval_evidence_type ON model_operations.approval_evidence(evidence_type);
+CREATE INDEX IF NOT EXISTS ix_approval_evidence_correlation_id ON model_operations.approval_evidence(correlation_id);

-IF NOT EXISTS (SELECT 1 FROM information_schema.tables WHERE table_name = 'approval_events' AND table_schema = 'model_operations')
-BEGIN
-    CREATE TABLE model_operations.approval_events (
-        id UUID PRIMARY KEY,
-        approval_proposal_id UUID NOT NULL REFERENCES model_operations.approval_proposals(id),
-        event_type VARCHAR(50) NOT NULL,
-        actor_email VARCHAR(255) NOT NULL,
-        event_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
-        details JSONB,
-        published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
-        correlation_id UUID NOT NULL
-    );
+CREATE TABLE IF NOT EXISTS model_operations.approval_events (
+    id UUID PRIMARY KEY,
+    approval_proposal_id UUID NOT NULL REFERENCES model_operations.approval_proposals(id),
+    event_type VARCHAR(50) NOT NULL,
+    actor_email VARCHAR(255) NOT NULL,
+    event_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    details JSONB,
+    published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    correlation_id UUID NOT NULL
+);

-    CREATE INDEX ix_approval_events_proposal_id ON model_operations.approval_events(approval_proposal_id);
-    CREATE INDEX ix_approval_events_type ON model_operations.approval_events(event_type);
-    CREATE INDEX ix_approval_events_correlation_id ON model_operations.approval_events(correlation_id);
-END;
+CREATE INDEX IF NOT EXISTS ix_approval_events_proposal_id ON model_operations.approval_events(approval_proposal_id);
+CREATE INDEX IF NOT EXISTS ix_approval_events_type ON model_operations.approval_events(event_type);
+CREATE INDEX IF NOT EXISTS ix_approval_events_correlation_id ON model_operations.approval_events(correlation_id);
@@ -0,0 +1,43 @@
+-- Migration 0038: Sell Decision Engine schema (VS-10)
+-- Creates tables for sell decision generation, validation, and approval tracking
+
+CREATE TABLE IF NOT EXISTS model_operations.sell_decisions (
+    id UUID PRIMARY KEY,
+    model_id UUID NOT NULL REFERENCES model_operations.models(id),
+    status VARCHAR(50) NOT NULL,
+    pbo_score DECIMAL(5,4),
+    dsr_metric DECIMAL(5,4),
+    oos_performance JSONB,
+    sell_priority INT,
+    target_quantity INT,
+    target_price DECIMAL(15,2),
+    approval_id UUID REFERENCES model_operations.approval_proposals(id),
+    execution_id UUID,
+    created_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    created_by VARCHAR(255) NOT NULL,
+    created_justification TEXT,
+    published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    correlation_id UUID NOT NULL,
+    revision INT NOT NULL DEFAULT 1
+);
+
+CREATE INDEX IF NOT EXISTS ix_sell_decisions_model_id ON model_operations.sell_decisions(model_id);
+CREATE INDEX IF NOT EXISTS ix_sell_decisions_status ON model_operations.sell_decisions(status);
+CREATE INDEX IF NOT EXISTS ix_sell_decisions_correlation_id ON model_operations.sell_decisions(correlation_id);
+CREATE INDEX IF NOT EXISTS ix_sell_decisions_published_at ON model_operations.sell_decisions(published_at DESC);
+
+CREATE TABLE IF NOT EXISTS model_operations.sell_decision_evidence (
+    id UUID PRIMARY KEY,
+    decision_id UUID NOT NULL REFERENCES model_operations.sell_decisions(id),
+    evidence_type VARCHAR(50) NOT NULL,
+    evidence_url TEXT NOT NULL,
+    validated_at TIMESTAMPTZ,
+    validator_email VARCHAR(255),
+    comments TEXT,
+    published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    correlation_id UUID NOT NULL
+);
+
+CREATE INDEX IF NOT EXISTS ix_sell_decision_evidence_decision_id ON model_operations.sell_decision_evidence(decision_id);
+CREATE INDEX IF NOT EXISTS ix_sell_decision_evidence_type ON model_operations.sell_decision_evidence(evidence_type);
+CREATE INDEX IF NOT EXISTS ix_sell_decision_evidence_correlation_id ON model_operations.sell_decision_evidence(correlation_id);
@@ -0,0 +1,44 @@
+-- Migration 0039: Trade execution schema (VS-12)
+-- Creates tables for KIS-integrated trade execution with full audit trail
+
+CREATE TABLE IF NOT EXISTS model_operations.trades (
+    id UUID PRIMARY KEY,
+    sell_decision_id UUID NOT NULL REFERENCES model_operations.sell_decisions(id),
+    kis_order_id VARCHAR(50),
+    status VARCHAR(50) NOT NULL DEFAULT 'PENDING',
+    quantity INT NOT NULL,
+    executed_quantity INT,
+    unit_price DECIMAL(15,2),
+    total_amount DECIMAL(18,2),
+    commission DECIMAL(15,2),
+    net_proceeds DECIMAL(18,2),
+    error_message TEXT,
+    kis_response JSONB,
+    execution_timestamp TIMESTAMPTZ,
+    settlement_timestamp TIMESTAMPTZ,
+    published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    correlation_id UUID NOT NULL,
+    revision INT NOT NULL DEFAULT 1
+);
+
+CREATE INDEX IF NOT EXISTS idx_trades_sell_decision_id ON model_operations.trades(sell_decision_id);
+CREATE INDEX IF NOT EXISTS idx_trades_status ON model_operations.trades(status);
+CREATE INDEX IF NOT EXISTS idx_trades_kis_order_id ON model_operations.trades(kis_order_id);
+CREATE INDEX IF NOT EXISTS idx_trades_correlation_id ON model_operations.trades(correlation_id);
+CREATE INDEX IF NOT EXISTS idx_trades_published_at ON model_operations.trades(published_at DESC);
+
+CREATE TABLE IF NOT EXISTS model_operations.trade_status_history (
+    id UUID PRIMARY KEY,
+    trade_id UUID NOT NULL REFERENCES model_operations.trades(id),
+    old_status VARCHAR(50),
+    new_status VARCHAR(50) NOT NULL,
+    transitioned_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    kis_response JSONB,
+    error_message TEXT,
+    published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    correlation_id UUID NOT NULL
+);
+
+CREATE INDEX IF NOT EXISTS idx_trade_status_history_trade_id ON model_operations.trade_status_history(trade_id);
+CREATE INDEX IF NOT EXISTS idx_trade_status_history_new_status ON model_operations.trade_status_history(new_status);
+CREATE INDEX IF NOT EXISTS idx_trade_status_history_correlation_id ON model_operations.trade_status_history(correlation_id);
@@ -0,0 +1,75 @@
+-- Migration 0040: Portfolio Reconciliation Schema (VS-14)
+-- Creates tables for holdings tracking, cost basis, and reconciliation logs
+
+CREATE SCHEMA IF NOT EXISTS portfolio_management;
+
+CREATE TABLE IF NOT EXISTS portfolio_management.holdings (
+    id UUID PRIMARY KEY,
+    security_id UUID NOT NULL,
+    quantity INT NOT NULL DEFAULT 0,
+    weighted_avg_cost DECIMAL(15,2) NOT NULL DEFAULT 0,
+    total_cost_basis DECIMAL(18,2) NOT NULL DEFAULT 0,
+    market_value DECIMAL(18,2),
+    unrealized_gain_loss DECIMAL(18,2),
+    updated_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    correlation_id UUID NOT NULL,
+    revision INT NOT NULL DEFAULT 1,
+
+    CONSTRAINT chk_quantity_non_negative CHECK (quantity >= 0),
+    CONSTRAINT chk_cost_basis_non_negative CHECK (total_cost_basis >= 0)
+);
+
+CREATE INDEX IF NOT EXISTS idx_holdings_security_id ON portfolio_management.holdings(security_id);
+CREATE INDEX IF NOT EXISTS idx_holdings_correlation_id ON portfolio_management.holdings(correlation_id);
+CREATE INDEX IF NOT EXISTS idx_holdings_updated_at ON portfolio_management.holdings(updated_at DESC);
+
+CREATE TABLE IF NOT EXISTS portfolio_management.reconciliation_logs (
+    id UUID PRIMARY KEY,
+    trade_id UUID NOT NULL,
+    holding_id UUID NOT NULL REFERENCES portfolio_management.holdings(id),
+    quantity_before INT,
+    quantity_after INT,
+    cost_basis_delta DECIMAL(18,2),
+    unrealized_gain_loss_delta DECIMAL(18,2),
+    mismatch_detected BOOLEAN DEFAULT FALSE,
+    mismatch_reason VARCHAR(255),
+    reconciled_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    correlation_id UUID NOT NULL,
+
+    CONSTRAINT chk_mismatch_reason_when_detected
+        CHECK (NOT mismatch_detected OR mismatch_reason IS NOT NULL)
+);
+
+CREATE INDEX IF NOT EXISTS idx_reconciliation_logs_trade_id ON portfolio_management.reconciliation_logs(trade_id);
+CREATE INDEX IF NOT EXISTS idx_reconciliation_logs_holding_id ON portfolio_management.reconciliation_logs(holding_id);
+CREATE INDEX IF NOT EXISTS idx_reconciliation_logs_mismatch ON portfolio_management.reconciliation_logs(mismatch_detected);
+CREATE INDEX IF NOT EXISTS idx_reconciliation_logs_correlation_id ON portfolio_management.reconciliation_logs(correlation_id);
+CREATE INDEX IF NOT EXISTS idx_reconciliation_logs_reconciled_at ON portfolio_management.reconciliation_logs(reconciled_at DESC);
+
+CREATE TABLE IF NOT EXISTS portfolio_management.lots (
+    id UUID PRIMARY KEY,
+    holding_id UUID NOT NULL REFERENCES portfolio_management.holdings(id),
+    purchase_date DATE NOT NULL,
+    quantity INT NOT NULL,
+    unit_cost DECIMAL(15,2) NOT NULL,
+    total_cost DECIMAL(18,2) NOT NULL,
+    status VARCHAR(50) NOT NULL DEFAULT 'OPEN',
+    fifo_order INT NOT NULL,
+    published_at TIMESTAMPTZ NOT NULL DEFAULT NOW(),
+    correlation_id UUID NOT NULL,
+
+    CONSTRAINT chk_lot_quantity_positive CHECK (quantity > 0),
+    CONSTRAINT chk_lot_status CHECK (status IN ('OPEN', 'PARTIAL_SOLD', 'CLOSED'))
+);
+
+CREATE INDEX IF NOT EXISTS idx_lots_holding_id ON portfolio_management.lots(holding_id);
+CREATE INDEX IF NOT EXISTS idx_lots_status ON portfolio_management.lots(status);
+CREATE INDEX IF NOT EXISTS idx_lots_fifo_order ON portfolio_management.lots(holding_id, fifo_order);
+CREATE INDEX IF NOT EXISTS idx_lots_correlation_id ON portfolio_management.lots(correlation_id);
+
+-- Grant permissions (adjust to match your security model)
+GRANT SELECT, INSERT ON portfolio_management.holdings TO kartsell;
+GRANT SELECT, INSERT ON portfolio_management.reconciliation_logs TO kartsell;
+GRANT SELECT, INSERT ON portfolio_management.lots TO kartsell;