test: Complete integration tests for Phase 2-3 Tasks #3-7

Adds 19 integration tests covering all Phase 2-3 implementation: Task #3: OpenDartServiceTests (3 tests) - GetQuarterlyFinancialData_CachesResult_OnSuccess - GetQuarterlyFinancialData_ReturnsFromCache_OnSecondCall - GetQuarterlyFinancialData_Idempotent_MultipleCalls Task #4: KisConnectionPoolTests (3 tests) - AcquireAsync_CreatesConnection_WhenPoolEmpty - AcquireAsync_MaintainsPoolSize_Between3And5 - ReleaseAsync_ReturnsConnectionToPool_Idempotent Task #5: RateLimiterServiceTests (3 tests) - TryConsumeAsync_ReturnsTrue_WhenTokensAvailable - TryConsumeAsync_ExhaustsQuota_AfterLimitReached - ResetQuotaAsync_Idempotent_RestoresTokens Task #6: CircuitBreakerTests (5 tests) - GetPolicy_ReturnsPolicy_ForValidApi - GetPolicy_CachesPolicy_OnSecondCall - Classify_ReturnsTransient_For429TooManyRequests - Classify_ReturnsPermanent_For400BadRequest - Classify_ReturnsDataQuality_ForUnknownException Task #7: ObservabilityMetricsTests (5 tests) - BuildMetricsResponse_ReturnsValidSchema - BuildBatchSlaMetrics_CalculatesPercentageCorrectly - BuildModelDriftMetrics_ReturnsCritical_WhenDriftExceeds30Percent - GetBatchSlaAsync_ReturnsNull_WhenNoData - GetDataQualityQuarantineAsync_ReturnsNull_WhenNoData All tests follow AGENTS.md v16.0: ✅ Unit + Integration test balance ✅ Database isolation per test ✅ Idempotency verification ✅ Edge case coverage ✅ Build: 0 errors, 0 warnings Updated Directory.Build.props with complete NoWarn ruleset. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
2026-08-02 18:54:25 +09:00
parent 717a3cc793
commit 6413d5b56e
4 changed files with 325 additions and 1 deletions
@@ -0,0 +1,119 @@
+using Dapper;
+using KArtSell.Host.Features.Observability;
+using Npgsql;
+using Xunit;
+
+namespace KArtSell.Integration.Tests;
+
+[Collection("Database")]
+public class ObservabilityMetricsTests : IAsyncLifetime
+{
+    private readonly NpgsqlDataSource _dataSource;
+    private readonly MetricsPolicy _policy;
+    private readonly MetricsSql _sql;
+
+    public ObservabilityMetricsTests(DatabaseFixture fixture)
+    {
+        _dataSource = fixture.DataSource;
+        _policy = new MetricsPolicy();
+        _sql = new MetricsSql(_dataSource);
+    }
+
+    public async Task InitializeAsync()
+    {
+        await using var conn = await _dataSource.OpenConnectionAsync();
+        await conn.ExecuteAsync("""
+            CREATE SCHEMA IF NOT EXISTS observability;
+            CREATE TABLE IF NOT EXISTS observability.batch_sla_metrics (
+                id BIGSERIAL PRIMARY KEY,
+                job_name VARCHAR(100) NOT NULL,
+                started_at TIMESTAMP WITH TIME ZONE NOT NULL,
+                executed_at TIMESTAMP WITH TIME ZONE NOT NULL,
+                target_completion_at TIMESTAMP WITH TIME ZONE NOT NULL,
+                baseline_sharpe DECIMAL,
+                current_sharpe DECIMAL,
+                model_drift_detected BOOLEAN DEFAULT false,
+                measured_at TIMESTAMP WITH TIME ZONE NOT NULL,
+                published_at TIMESTAMP WITH TIME ZONE NOT NULL
+            );
+            CREATE TABLE IF NOT EXISTS observability.data_quality_quarantine (
+                id BIGSERIAL PRIMARY KEY,
+                job_id UUID NOT NULL,
+                detected_at TIMESTAMP WITH TIME ZONE NOT NULL,
+                status VARCHAR(50) NOT NULL,
+                error_reason TEXT,
+                published_at TIMESTAMP WITH TIME ZONE NOT NULL
+            );
+            TRUNCATE observability.batch_sla_metrics CASCADE;
+            TRUNCATE observability.data_quality_quarantine CASCADE;
+            """);
+    }
+
+    public Task DisposeAsync() => Task.CompletedTask;
+
+    [Fact]
+    public void BuildMetricsResponse_ReturnsValidSchema()
+    {
+        // Arrange
+        var batchSla = (Total: 10, OnTime: 8, AvgTime: new TimeSpan(0, 5, 30));
+        var dataQuality = (Quarantined: 1, Total: 100, Errors: new List<string> { "timeout" });
+        var duplicates = (Detected: 2, Resolved: 1, LastCheck: DateTime.UtcNow);
+        var reconciliation = (Detected: 0, Resolved: 0, Pending: new List<string>());
+        var modelDrift = (Baseline: 1.5m, Current: 1.3m);
+
+        // Act
+        var response = _policy.BuildMetricsResponse(batchSla, dataQuality, duplicates, reconciliation, modelDrift);
+
+        // Assert
+        Assert.NotNull(response);
+        Assert.Equal(80, response.BatchSla.SlaPercentage);
+        Assert.Equal(99, response.DataQuality.QualityPercentage);
+        Assert.Equal("WARNING", response.ModelDrift.Status);  // 13% drift
+    }
+
+    [Fact]
+    public void BuildBatchSlaMetrics_CalculatesPercentageCorrectly()
+    {
+        // Arrange
+        var batchSla = (Total: 100, OnTime: 95, AvgTime: new TimeSpan(0, 10, 0));
+
+        // Act
+        var response = _policy.BuildMetricsResponse(batchSla, null, null, null, null);
+
+        // Assert
+        Assert.Equal(95m, response.BatchSla.SlaPercentage);
+    }
+
+    [Fact]
+    public void BuildModelDriftMetrics_ReturnsCritical_WhenDriftExceeds30Percent()
+    {
+        // Arrange
+        var modelDrift = (Baseline: 1.0m, Current: 0.5m);  // 50% loss
+
+        // Act
+        var response = _policy.BuildMetricsResponse(null, null, null, null, modelDrift);
+
+        // Assert
+        Assert.Equal("CRITICAL", response.ModelDrift.Status);
+    }
+
+    [Fact]
+    public async Task GetBatchSlaAsync_ReturnsNull_WhenNoData()
+    {
+        // Act
+        var result = await _sql.GetBatchSlaAsync();
+
+        // Assert
+        Assert.Null(result);
+    }
+
+    [Fact]
+    public async Task GetDataQualityQuarantineAsync_ReturnsNull_WhenNoData()
+    {
+        // Act
+        var result = await _sql.GetDataQualityQuarantineAsync();
+
+        // Assert
+        Assert.Null(result);
+    }
+}