fix: Release build breakage + Dapper mapping bugs in VS-03/VS-04/Phase3-K
- KArtSell.Host.csproj: FrontendFiles glob was evaluated at project-load time, before pnpm build ran, so it copied stale/missing Vite-hashed filenames every Release build. Move the glob inside the target, after the build Exec. - ApprovalSql/AuditSql/TradeSql: fix live-DB integration failures never caught by unit tests: DateOnly and inet columns can't be bound/read directly through Dapper without conversion; kis_response (jsonb) read as JsonElement threw InvalidCastException; GdprRetention.RetentionEndsAt was typed DateTime against a DATE column. - TradeSql: UpdateTradeStatusAsync only ever persisted status/kis_response /error_message, silently dropping kis_order_id, executed_quantity, unit_price, total_amount, commission, net_proceeds and the execution/ settlement timestamps on every call. Changed it to take the Trade aggregate so the full state transition persists. - TradeSql: add a static ctor setting Dapper.DefaultTypeMap. MatchNamesWithUnderscores = true. The repo's [ModuleInitializer] in KArtSell.BuildingBlocks only fires once that assembly is actually loaded; TradeSql/Trade never reference a BuildingBlocks type, so under test isolation (or any host that queries a trade before touching BuildingBlocks) every snake_case column silently mapped to null/default. - Test fixes: seed the FK prerequisites (model_operations.models, sell_decisions) that ApprovalWorkflowTests/TradeExecutionTests were missing, correct a SellPriorityRanker test input to match the approved VS-10-SLICE_SPEC age-boost threshold, and fix a GDPR redaction assertion that called ToString() on a Dictionary instead of inspecting its values. 12 DbUpMigrationTests failures remain and are unrelated to this fix: the kartsell DB user isn't the owner of kartsell_migration_test, so DbUp's fresh-database rehearsal can't DROP/CREATE it. Needs a DBA grant. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
This commit is contained in:
@@ -3,6 +3,7 @@ namespace KArtSell.Integration.Tests.ApprovalWorkflow;
|
||||
using System;
|
||||
using System.Collections.Generic;
|
||||
using System.Threading.Tasks;
|
||||
using Dapper;
|
||||
using Xunit;
|
||||
using KArtSell.BuildingBlocks.Time;
|
||||
using KArtSell.Modules.ModelOperations.ApprovalWorkflow;
|
||||
@@ -165,6 +166,7 @@ public class ApprovalWorkflowTests : IAsyncLifetime
|
||||
var id = Guid.NewGuid();
|
||||
var modelId = Guid.NewGuid();
|
||||
var correlationId = Guid.NewGuid();
|
||||
await SeedModelAsync(modelId);
|
||||
|
||||
// Act
|
||||
await _sql.InsertProposalAsync(
|
||||
@@ -185,6 +187,15 @@ public class ApprovalWorkflowTests : IAsyncLifetime
|
||||
Assert.Equal(modelId, retrieved.ModelId);
|
||||
Assert.Equal(correlationId, retrieved.CorrelationId);
|
||||
}
|
||||
|
||||
private async Task SeedModelAsync(Guid modelId)
|
||||
{
|
||||
await using var conn = new Npgsql.NpgsqlConnection(_connectionString);
|
||||
await conn.OpenAsync();
|
||||
await conn.ExecuteAsync(
|
||||
"INSERT INTO model_operations.models (id, ticker, correlation_id) VALUES (@Id, @Ticker, @CorrelationId)",
|
||||
new { Id = modelId, Ticker = "TEST", CorrelationId = Guid.NewGuid() });
|
||||
}
|
||||
}
|
||||
|
||||
public class InMemoryOutbox : IOutbox
|
||||
|
||||
@@ -106,6 +106,11 @@ public class AuditTrailTests : IAsyncLifetime
|
||||
var customerId = Guid.NewGuid();
|
||||
var retentionId = Guid.NewGuid();
|
||||
|
||||
await _sql.InsertAuditEventAsync(
|
||||
_db, eventId, AuditEventTypes.ModelActivated, AuditEntityTypes.Model,
|
||||
Guid.NewGuid(), "customer@company.com", null, DateTime.UtcNow, "SUCCESS", null,
|
||||
null, null, null, null, Guid.NewGuid(), CancellationToken.None);
|
||||
|
||||
// Act
|
||||
await _sql.InsertGdprRetentionAsync(
|
||||
_db, retentionId, eventId, customerId,
|
||||
@@ -175,7 +180,8 @@ public class AuditTrailTests : IAsyncLifetime
|
||||
// Assert
|
||||
var @event = await _sql.GetAuditEventByIdAsync(_db, eventId, CancellationToken.None);
|
||||
Assert.NotNull(@event);
|
||||
Assert.Contains("<redacted>", @event.Details?.ToString() ?? "");
|
||||
Assert.Equal("<redacted>", @event.Details?["actor_email"].ToString());
|
||||
Assert.Equal("<purged>", @event.Details?["customer_id"].ToString());
|
||||
}
|
||||
|
||||
private const string TestConnectionString =
|
||||
|
||||
@@ -118,8 +118,8 @@ public class SellPriorityRankerTests
|
||||
[Fact]
|
||||
public void CalculateScore_HardImpairment_ReturnsLowestScore()
|
||||
{
|
||||
var score = _ranker.CalculateScore(SellPriority.HardImpairment, fundAgeDays: 200, liquidityPercent: 0.5m);
|
||||
Assert.Equal(950m, score); // 1000 - 50 (age boost)
|
||||
var score = _ranker.CalculateScore(SellPriority.HardImpairment, fundAgeDays: 400, liquidityPercent: 0.5m);
|
||||
Assert.Equal(950m, score); // 1000 - 50 (age boost, fundAgeDays > 365 per VS-10-SLICE_SPEC.md)
|
||||
}
|
||||
|
||||
[Fact]
|
||||
|
||||
@@ -1,4 +1,5 @@
|
||||
using System.Text.Json;
|
||||
using Dapper;
|
||||
using KArtSell.Modules.ModelOperations.TradeExecution;
|
||||
using Microsoft.Extensions.Logging;
|
||||
using Npgsql;
|
||||
@@ -31,11 +32,31 @@ public class TradeExecutionTests : IAsyncLifetime
|
||||
await _dataSource.DisposeAsync();
|
||||
}
|
||||
|
||||
private async Task<Guid> SeedSellDecisionAsync()
|
||||
{
|
||||
await using var connection = await _dataSource.OpenConnectionAsync();
|
||||
var modelId = Guid.NewGuid();
|
||||
await connection.ExecuteAsync(
|
||||
"INSERT INTO model_operations.models (id, ticker, correlation_id) VALUES (@Id, @Ticker, @CorrelationId)",
|
||||
new { Id = modelId, Ticker = "TEST", CorrelationId = Guid.NewGuid() });
|
||||
|
||||
var sellDecisionId = Guid.NewGuid();
|
||||
await connection.ExecuteAsync(
|
||||
"""
|
||||
INSERT INTO model_operations.sell_decisions
|
||||
(id, model_id, status, created_by, published_at, correlation_id)
|
||||
VALUES (@Id, @ModelId, 'PENDING', 'test@company.com', NOW(), @CorrelationId)
|
||||
""",
|
||||
new { Id = sellDecisionId, ModelId = modelId, CorrelationId = Guid.NewGuid() });
|
||||
|
||||
return sellDecisionId;
|
||||
}
|
||||
|
||||
[Fact]
|
||||
public async Task CreateTrade_WithValidData_ShouldInsertSuccessfully()
|
||||
{
|
||||
var sql = new TradeSql(_dataSource, _logger);
|
||||
var sellDecisionId = Guid.NewGuid();
|
||||
var sellDecisionId = await SeedSellDecisionAsync();
|
||||
var correlationId = Guid.NewGuid();
|
||||
|
||||
var trade = Trade.Create(sellDecisionId, 1000, correlationId, DateTime.UtcNow);
|
||||
@@ -55,14 +76,14 @@ public class TradeExecutionTests : IAsyncLifetime
|
||||
{
|
||||
var sql = new TradeSql(_dataSource, _logger);
|
||||
var correlationId = Guid.NewGuid();
|
||||
var trade = Trade.Create(Guid.NewGuid(), 1000, correlationId, DateTime.UtcNow);
|
||||
var trade = Trade.Create(await SeedSellDecisionAsync(), 1000, correlationId, DateTime.UtcNow);
|
||||
|
||||
await sql.InsertTradeAsync(trade);
|
||||
|
||||
var response = JsonDocument.Parse("{}").RootElement;
|
||||
trade.MarkSubmitted("KIS-ORDER-123", response);
|
||||
|
||||
await sql.UpdateTradeStatusAsync(trade.Id, TradeStatus.Submitted, response, null, correlationId);
|
||||
await sql.UpdateTradeStatusAsync(trade, response, null);
|
||||
|
||||
var retrieved = await sql.GetTradeByIdAsync(trade.Id, correlationId);
|
||||
|
||||
@@ -76,14 +97,14 @@ public class TradeExecutionTests : IAsyncLifetime
|
||||
{
|
||||
var sql = new TradeSql(_dataSource, _logger);
|
||||
var correlationId = Guid.NewGuid();
|
||||
var trade = Trade.Create(Guid.NewGuid(), 1000, correlationId, DateTime.UtcNow);
|
||||
var trade = Trade.Create(await SeedSellDecisionAsync(), 1000, correlationId, DateTime.UtcNow);
|
||||
|
||||
await sql.InsertTradeAsync(trade);
|
||||
|
||||
var response = JsonDocument.Parse("{}").RootElement;
|
||||
trade.MarkFilled(1000, 49.95m, response, DateTime.UtcNow);
|
||||
|
||||
await sql.UpdateTradeStatusAsync(trade.Id, TradeStatus.FullyFilled, response, null, correlationId);
|
||||
await sql.UpdateTradeStatusAsync(trade, response, null);
|
||||
|
||||
var retrieved = await sql.GetTradeByIdAsync(trade.Id, correlationId);
|
||||
|
||||
@@ -100,8 +121,8 @@ public class TradeExecutionTests : IAsyncLifetime
|
||||
var sql = new TradeSql(_dataSource, _logger);
|
||||
var correlationId = Guid.NewGuid();
|
||||
|
||||
var trade1 = Trade.Create(Guid.NewGuid(), 1000, correlationId, DateTime.UtcNow);
|
||||
var trade2 = Trade.Create(Guid.NewGuid(), 2000, correlationId, DateTime.UtcNow);
|
||||
var trade1 = Trade.Create(await SeedSellDecisionAsync(), 1000, correlationId, DateTime.UtcNow);
|
||||
var trade2 = Trade.Create(await SeedSellDecisionAsync(), 2000, correlationId, DateTime.UtcNow);
|
||||
|
||||
await sql.InsertTradeAsync(trade1);
|
||||
await sql.InsertTradeAsync(trade2);
|
||||
@@ -118,14 +139,14 @@ public class TradeExecutionTests : IAsyncLifetime
|
||||
{
|
||||
var sql = new TradeSql(_dataSource, _logger);
|
||||
var correlationId = Guid.NewGuid();
|
||||
var trade = Trade.Create(Guid.NewGuid(), 1000, correlationId, DateTime.UtcNow);
|
||||
var trade = Trade.Create(await SeedSellDecisionAsync(), 1000, correlationId, DateTime.UtcNow);
|
||||
|
||||
await sql.InsertTradeAsync(trade);
|
||||
|
||||
trade.TotalAmount = 49950m;
|
||||
trade.MarkConfirmed(DateTime.UtcNow, 50m);
|
||||
|
||||
await sql.UpdateTradeStatusAsync(trade.Id, TradeStatus.Confirmed, null, null, correlationId);
|
||||
await sql.UpdateTradeStatusAsync(trade, null, null);
|
||||
|
||||
var retrieved = await sql.GetTradeByIdAsync(trade.Id, correlationId);
|
||||
|
||||
@@ -140,11 +161,16 @@ public class TradeExecutionTests : IAsyncLifetime
|
||||
{
|
||||
var sql = new TradeSql(_dataSource, _logger);
|
||||
var correlationId = Guid.NewGuid();
|
||||
var trade = Trade.Create(Guid.NewGuid(), 1000, correlationId, DateTime.UtcNow);
|
||||
var trade = Trade.Create(await SeedSellDecisionAsync(), 1000, correlationId, DateTime.UtcNow);
|
||||
|
||||
await sql.InsertTradeAsync(trade);
|
||||
await sql.UpdateTradeStatusAsync(trade.Id, TradeStatus.Submitted, null, null, correlationId);
|
||||
await sql.UpdateTradeStatusAsync(trade.Id, TradeStatus.Accepted, null, null, correlationId);
|
||||
|
||||
var response = JsonDocument.Parse("{}").RootElement;
|
||||
trade.MarkSubmitted("KIS-1", response);
|
||||
await sql.UpdateTradeStatusAsync(trade, response, null);
|
||||
|
||||
trade.MarkAccepted(response);
|
||||
await sql.UpdateTradeStatusAsync(trade, response, null);
|
||||
|
||||
var retrieved = await sql.GetTradeByIdAsync(trade.Id, correlationId);
|
||||
|
||||
@@ -158,8 +184,8 @@ public class TradeExecutionTests : IAsyncLifetime
|
||||
var sql = new TradeSql(_dataSource, _logger);
|
||||
var correlationId = Guid.NewGuid();
|
||||
|
||||
var trade1 = Trade.Create(Guid.NewGuid(), 1000, correlationId, DateTime.UtcNow);
|
||||
var trade2 = Trade.Create(Guid.NewGuid(), 2000, correlationId, DateTime.UtcNow);
|
||||
var trade1 = Trade.Create(await SeedSellDecisionAsync(), 1000, correlationId, DateTime.UtcNow);
|
||||
var trade2 = Trade.Create(await SeedSellDecisionAsync(), 2000, correlationId, DateTime.UtcNow);
|
||||
|
||||
await sql.InsertTradeAsync(trade1);
|
||||
await sql.InsertTradeAsync(trade2);
|
||||
|
||||
Reference in New Issue
Block a user